GeneralChaos
Versed in the lewd.
- Joined
- Apr 25, 2014
- Messages
- 1,613
- Likes received
- 7,297
The threadmark filtering system is having false negative issues. @havefeith reported them here.
Steps to reproduce: Go to the [NSFW] You wake up as... (General Self-Insert Thread) thread. Click on the threadmarks dropdown, then View All 645 Threadmarks. Paste "Jack of Olives - My Misty Adventures at the Madhouse" into the Filter box. You should see entries 1, 2 and 4 show up, but not 3. Clear the Filter box, then type in "My Misty". You should see all four links. Copy+Paste the text of the third link into the filter box, and it will not show up.
Something is specifically wrong between the hyphen and the M in "My". Delete everything after the hyphen's space, ctrl+f for "misty", and you'll find that the link to Misty Adventures 3 is present. Add an 'M' back, and the relevant link has disappeared. From the other direction, paste " My Misty Adventures at the Madhouse 3" and the link will show. Add a hyphen to the beginning, and the link will disappear. I'd guess that the space just gets trimmed off, but I don't know what exactly is going wrong here. I do know that it's not a non-breaking space, because I tried using one of those and the link didn't show.
Edited to add: I found the problem! There are two spaces between the hyphen and the 'M'! It only showed up on the browser inspector for some reason. Xenforo collapses duplicate spaces when displaying messages, so I guess it's doing the same thing here. Combine that with the exact matching to the threadmark name as stored in the database, counting the duplicate? A recipe for false negatives.
I think the solution for this is @KinKrow (or maybe a mod) to clean up the double-spaces. A more permanent solution may be for Xon to trim whitespace in the threadmark filtering. If the current version of Threadmarks Pro already assumes and enforces that threadmarks don't have multiple spaces but they snuck in with the Xenforo 2 migration, the admins could purge all double-spaces from existing threadmark names.
Steps to reproduce: Go to the [NSFW] You wake up as... (General Self-Insert Thread) thread. Click on the threadmarks dropdown, then View All 645 Threadmarks. Paste "Jack of Olives - My Misty Adventures at the Madhouse" into the Filter box. You should see entries 1, 2 and 4 show up, but not 3. Clear the Filter box, then type in "My Misty". You should see all four links. Copy+Paste the text of the third link into the filter box, and it will not show up.
Something is specifically wrong between the hyphen and the M in "My". Delete everything after the hyphen's space, ctrl+f for "misty", and you'll find that the link to Misty Adventures 3 is present. Add an 'M' back, and the relevant link has disappeared. From the other direction, paste " My Misty Adventures at the Madhouse 3" and the link will show. Add a hyphen to the beginning, and the link will disappear. I'd guess that the space just gets trimmed off, but I don't know what exactly is going wrong here. I do know that it's not a non-breaking space, because I tried using one of those and the link didn't show.
Edited to add: I found the problem! There are two spaces between the hyphen and the 'M'! It only showed up on the browser inspector for some reason. Xenforo collapses duplicate spaces when displaying messages, so I guess it's doing the same thing here. Combine that with the exact matching to the threadmark name as stored in the database, counting the duplicate? A recipe for false negatives.
I think the solution for this is @KinKrow (or maybe a mod) to clean up the double-spaces. A more permanent solution may be for Xon to trim whitespace in the threadmark filtering. If the current version of Threadmarks Pro already assumes and enforces that threadmarks don't have multiple spaces but they snuck in with the Xenforo 2 migration, the admins could purge all double-spaces from existing threadmark names.
Last edited: